Support GitHub Enterprise server in plugin/load_db service#2356
Draft
ddelnano wants to merge 1 commit intopixie-io:mainfrom
Draft
Support GitHub Enterprise server in plugin/load_db service#2356ddelnano wants to merge 1 commit intopixie-io:mainfrom
ddelnano wants to merge 1 commit intopixie-io:mainfrom
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 10ba426)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Support GitHub Enterprise server in plugin/load_db service
The airgapped install does not support the Pixie plugin system. For environments that have access to a self-hosted GitHub Enterprise server, the load_db service can use the same API as long as an appropriate hostname is provided. This unblocks an end user from using the pixie plugin system.
Relevant Issues: N/A
Type of change: /kind bugfix
Test Plan: End user tested out an image and verified their plugin system is now functional (waiting for confirmation)
Changelog Message: Pixie plugin system now supported for airgapped installs that have access to GitHub Enterprise server